On 4/25/2016 2:35 PM, Stephen Boyd wrote: > On 04/25, Frank Rowand wrote: >> >> This is in msm_request_tx_dma(). I should have made the message >> "msm_serial: TX DMA not enabled\n" and added a similar message >> to msm_request_rx_dma(). >> >> Then it could print twice, once for TX and once for RX. :-) >> For my board it would print twice because both requests would >> fail for the same reason. > > Ah right, the 3 line diff window caught me here. > >> >> Should I add it to msm_request_rx_dma() also, but make both >> locations dev_debug() instead of dev_info()? > > Honestly I don't see much point in having this at all. Why does > the user care if DMA is used or not? Don't they just want the > hardware to work? Maybe dev_dbg(), but again, debug junk. I'll > leave it up to you and Greg. If the user doesn't care if DMA is used then why even bother implementing it in the driver? :-) I don't _need_ the messages, I just need the driver to quit dropping bytes and writing corrupt bytes. So patch 1 of 2 is sufficient for my needs. -Frank -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
