On Fri, Apr 29, 2016 at 07:56:16AM +0000, David Binderman wrote: > Hello there, > > ---------------------------------------- > >> I know about 35 other cases like this, scattered across the Linux kernel. > > > > Great, submit away! > > Done 25, but these remaining ten seem to have no entry in the MAINTAINERS > list and so be orphans that no one wants to fix: > > [linux-4.6-rc5/drivers/firmware/edd.c:706]: (style) Redundant condition: attr.test. '!attr.test || (attr.test && attr.test(edev))' is equivalent to '!attr.test || attr.test(edev)' > [linux-4.6-rc5/drivers/firmware/qcom_scm-32.c:416]: (style) Redundant condition: cpus. '!cpus || (cpus && cpumask_empty(cpus))' is equivalent to '!cpus || cpumask_empty(cpus)' > [linux-4.6-rc5/drivers/mtd/chips/cfi_cmdset_0002.c:569]: (style) Redundant condition: extp.MajorVersion=='1'. 'A || (!A && B)' is equivalent to 'A || B' > [linux-4.6-rc5/drivers/net/ethernet/freescale/fman/fman.c:2329]: (style) Redundant condition: fman.state.port_mfl[mac_id]. '!A || (A && B)' is equivalent to '!A || B' > [linux-4.6-rc5/drivers/net/fjes/fjes_main.c:1273]: (style) Redundant condition: !is_shared. 'is_shared && (!is_shared || !stop_req_done)' is equivalent to 'is_shared && !stop_req_done' > [linux-4.6-rc5/drivers/net/xen-netfront.c:1567]: (style) Redundant condition: feature_split_evtchn. '!feature_split_evtchn || (feature_split_evtchn && err)' is equivalent to '!feature_split_evtchn || err' > [linux-4.6-rc5/drivers/platform/x86/wmi.c:523]: (style) Redundant condition: wmi_status==AE_OK. 'A || (!A && B)' is equivalent to 'A || B' > [linux-4.6-rc5/drivers/platform/x86/wmi.c:567]: (style) Redundant condition: wmi_status==AE_OK. 'A || (!A && B)' is equivalent to 'A || B' > [linux-4.6-rc5/drivers/usb/host/fhci-sched.c:291]: (style) Redundant condition: td. '!td || (td && td.status==2147483648)' is equivalent to '!td || td.status==2147483648' > [linux-4.6-rc5/tools/net/bpf_dbg.c:1198]: (style) Redundant condition: has_limit. '!has_limit || (has_limit && ++i<pkts)' is equivalent to '!has_limit || ++i<pkts' > > Given that they are not high priority, I would welcome any advice on what to do with them. Use scripts/get_maintainer.pl to find the mailing list and/or people to send them to. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
