Re: [PATCH] serial: 8250: Integrate Fintek into pnp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/28/2016 12:19 AM, Ricardo Ribalda Delgado wrote:
> Hi
> 
> On Wed, Jan 27, 2016 at 11:22 PM, Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> wrote:
>> Does one of the ACPI SYS descriptors at least claim ioport 2e-2f
>> or 4e-4f?
> 
> I found this one.

Ok, well that's good.


>  Device (SYSR)
>                 {
>                     Name (_HID, EisaId ("PNP0C02") /* PNP Motherboard
> Resources */)  // _HID: Hardware ID
>                     Name (_UID, 0x02)  // _UID: Unique ID
>                     Name (_CRS, ResourceTemplate ()  // _CRS: Current
> Resource Settings
>                     {
>                         IO (Decode16,
>                             0x0022,             // Range Minimum
>                             0x0022,             // Range Maximum
>                             0x01,               // Alignment
>                             0x02,               // Length
>                             )
>                         IO (Decode16,
>                             0x002E,             // Range Minimum
>                             0x002E,             // Range Maximum
>                             0x01,               // Alignment
>                             0x02,               // Length
>                             )
>                         IO (Decode16,
>                             0x004E,             // Range Minimum
>                             0x004E,             // Range Maximum
>                             0x01,               // Alignment
>                             0x02,               // Length
>                             )
> ...
> 
> 
>>
>>> If I have to guess I would say that all the fintek serial ports on the
>>> field are declared only as PNP0501, not only my board :S
>>
>> Probably.
>>
>> Now I'm wondering if we should just probe this as a standard part of
>> the 8250 port driver's autoconfig() instead.
>>
>> The PNP id isn't really adding more confidence to whether this is a
>> Super I/O device.
> 
> I dont think that I  fully understand you here. Do you mean that
> fintek_8250_proble should be called inside
> 
> autoconfig in8250_port.c, regardless its pnp id?

Well, the probe would be in autoconfig_16550a(), but not the configuration.
Basically, the probe would go see if there was _any_ super i/o ports, and
then try known values like the Fintek ids. All that would do though would
assign a port type (PORT_F81216A for example). The specific configuration
differences would be elsewhere, like in the uart_config[] table and such.

Let me see if I can come up with a lightweight framework this weekend, and
then you can flesh it out with the specifics.

> Thanks  for your help!

No worries.

Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux