Re: [PATCH v2] serial: imx: Disable irqs before requesting them

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 17, 2015 at 09:51:21AM -0300, Fabio Estevam wrote:
> +	/* Disable interrupts before requesting them */
> +	reg = readl(sport->port.membase + UCR1);
> +	reg &= ~(UCR1_ADEN | UCR1_TRDYEN | UCR1_IDEN | UCR1_RRDYEN |
> +		 UCR1_TXMPTYEN | UCR1_RTSDEN);
> +	writel(reg, sport->port.membase + UCR1);

Since we now have generic relaxed IO ops, do these need to be the
strongly barriered versions?  It doesn't matter much, but someone at
some point may like to consider migrating the driver to relaxed IO
ops.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux