On Thu, Feb 19, 2015 at 10:45:47AM +0100, aurélien bouin wrote: > I hope this link will be ok : > http://marc.info/?l=linux-kernel&m=142366865609389&q=raw Good heavens, this patch is broken. It depends on user space to get the reference counting for the gpio right if at all. It uses a reserved part of the struct serial_rs485 while being driver specific. It ignores gpio_request returning an error (well, it does a dev_err in this case, but continues to use the gpio). It does change how frame error are handled even if rs485 is off without mentioning in the changelog. Are you aware what happens if a user issues the rs485 callback without being aware that padding[0] has this meaning? I'm sorry, I like my patch better. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
