Mike Christie wrote:
James.Smart@xxxxxxxxxx wrote:
-----Original Message-----
From: Mike Christie [mailto:michaelc@xxxxxxxxxxx]
So during a clean shutdown are drivers supposed to remove
the targets by
calling scsi_remove_target to remove the devices, then
remove the rports
through the class?
Or for the case where we are stopping a host (rmmod or single
host stop
like with fcoe), should drivers call
Yes - the steps below is what the drivers do today. And this does all
work without failing the cache sync (unless something's changed recently
in the midlayer above us).
You mean if I do rmmod lpfc it should work today? I do not think it
works anymore because in fc_remove_host we do this:
fc_remove_host()
/* Remove any remote ports */
list_for_each_entry_safe(rport, next_rport,
&fc_host->rports, peers) {
list_del(&rport->peers);
rport->port_state = FC_PORTSTATE_DELETED;
fc_queue_work(shost, &rport->rport_delete_work);
}
We set the rport->port_state to deleted before removing the target, so
when the cache sync is sent later as a result of fc_rport_final_delete
calling scsi_remove_target, the fc_remote_port_chkready checks in lpfc
or qla2xxx or mpt's queeucommand will fail the command with
DID_NO_CONNECT (fc_remote_port_chkready will
oops that got cut off. I mean to write fc_remote_port_chkready will do this:
fc_remote_port_chkready(struct fc_rport *rport)
{
int result;
switch (rport->port_state) {
case FC_PORTSTATE_ONLINE:
if (rport->roles & FC_PORT_ROLE_FCP_TARGET)
result = 0;
else if (rport->flags & FC_RPORT_DEVLOSS_PENDING)
result = DID_IMM_RETRY << 16;
else
result = DID_NO_CONNECT << 16;
break;
case FC_PORTSTATE_BLOCKED:
result = DID_IMM_RETRY << 16;
break;
default:
result = DID_NO_CONNECT << 16;
break;
So because port_state == FC_PORTSTATE_DELETED we reutrn DID_NO_CONNECT
on any IO like the cache sync that gets sent.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
