On Mon, Mar 03, 2008 at 10:40:10AM +0000, Russell King wrote:
> On Mon, Mar 03, 2008 at 11:19:46AM +0100, Christof Schmitt wrote:
> > +static int zfcp_scsi_eh_target_reset_handler(struct scsi_cmnd *scpnt)
> > +{
> > + int retval;
> > + struct zfcp_unit *unit = (struct zfcp_unit *) scpnt->device->hostdata;
>
> Randomly spotted item. Isn't hostdata of type void *?
>
> void *hostdata; /* available to low-level driver */
>
> in which case, isn't that cast, which is being added, redundant?
True. The cast was there before, but only in the device_reset_handler.
When touching the code now, we can as well remove it.
--
Christof Schmitt
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
