Re: [PATCH] zfcp: convert zfcp to use target reset and device reset handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>  	if (!unit) {
> -		ZFCP_LOG_NORMAL("bug: Tried reset for nonexistent unit\n");
> -		retval = SUCCESS;
> -		goto out;
> +		BUG();
> +		return SUCCESS;
> [...]
> +	if (!unit) {
> +		BUG();
> +		return SUCCESS;

Would you mind turning the BUG()s into WARN_ON(1)s? BUG() may crash the
whole system, while WARN_ON() will just emit a warning and continue.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux