> if (!unit) { > - ZFCP_LOG_NORMAL("bug: Tried reset for nonexistent unit\n"); > - retval = SUCCESS; > - goto out; > + BUG(); > + return SUCCESS; > [...] > + if (!unit) { > + BUG(); > + return SUCCESS; Would you mind turning the BUG()s into WARN_ON(1)s? BUG() may crash the whole system, while WARN_ON() will just emit a warning and continue. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html