On Mon, Mar 03, 2008 at 10:39:24AM +0100, Heiko Carstens wrote:
> > if (!unit) {
> > - ZFCP_LOG_NORMAL("bug: Tried reset for nonexistent unit\n");
> > - retval = SUCCESS;
> > - goto out;
> > + BUG();
> > + return SUCCESS;
> > [...]
> > + if (!unit) {
> > + BUG();
> > + return SUCCESS;
>
> Would you mind turning the BUG()s into WARN_ON(1)s? BUG() may crash the
> whole system, while WARN_ON() will just emit a warning and continue.
Agree, WARN_ON is enough for these cases. I will followup with the
changed patch.
--
Christof Schmitt
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
