On 02/14/2006 02:24:47 PM, Christoph Hellwig wrote:
Looks good. I didn't think about keeping the reuse and dealing with it in osst_do_scsi, but this obviously works. Please tell if you're confident enough with it so we can put it in the for-2.6.17 tree. Long-term we should probably get rid of the request reuse anyway, because it's not nessecary anymore and would make the code more readable.
I agree that would make the code easier to understand, but it will be a significant impact on the logic of the driver, whereas the current patch is relatively low impact. Which is exactly the reason why, yes, I do feel the change can at least be put in the -mm series and then migrate if we don't get any problem reports.
Thanks, Willem Riede. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html