On Mon, Feb 06, 2006 at 08:02:21PM -0500, Willem Riede wrote: > On 02/06/2006 08:19:44 AM, Christoph Hellwig wrote: > >Hi Willem, > > > >do you still maintain the osst driver? We're moving forward to > >completly get rid of the scsi_request structure in the scsi midlayer, > >and osst is the only upper level driver still using it. I've tried to > >convert it similar to st, but gave up. The biggest problem for me is > >the scsi_request reuse over the driver where a pointer to a pointer to > >a scsi_request is passed along all the callchain, and I have a really > >hard time to find out whether the functions actually looks it, or only > > "looks it"?? don't understand :-( sorry, should have read "looks at it" as in examines fields in the request or looks at the result of performing the scsi command. > But I will certainly help retire scsi_request. And anything else that is > needed to keep up with proper kernel style. Let me know what those are, if > you would? I'll start looking at how st has changed, and will be back with > any questions I may have. right now the above is the most urgent bit. What would be nice but not required is a conversion to the sense handling helpers, similar to what st got (aka using the *normalize_sense functions and then dealing with the parsed sense buffer instead of the raw sense data) - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
