On Sun, 2006-02-19 at 16:08 +0100, Jürgen E. Fischer wrote: > > The driver still seems to have an awful lot of locking confusion between > > the host lock and its own internal lock (stored in the host structure). > > I think there are several races and other nasties that could be cleaned > > up simply by moving to using the host lock everywhere. > > done. > > patch: > - drop private lock and use host_lock instead. > > Signed-off-by: Juergen E. Fischer <fischer@xxxxxxxxxxxxxxxx> > > --- aha152x.c 2006-02-19 15:54:24.315291253 +0100 > +++ linux-2.6/drivers/scsi/aha152x.c 2006-02-19 16:00:45.817015449 +0100 > @@ -465,9 +465,6 @@ > Scsi_Cmnd *done_SC; > /* command that was completed */ > > - spinlock_t lock; > - /* host lock */ > - Actually, unfortunately, it doesn't look to be quite as simple as that ... there are places (in ahd542x_queue_internal) where both locks are currently held. Perhaps I should just put the complete fix of the previous patch in for 2.6.16 and then the locking changes can be worked on post 2.6.16 (as in two separate patches) James - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
