On 2/16/25 11:36, Krzysztof Kozlowski wrote: > On 15/02/2025 13:24, Ivaylo Ivanov wrote: >> The Exynos2200 SoC comes with 3 PHYs - snps eUSB2, snps USBDP combophy >> and a cut-off phy that origins from exynos5-usbdrd. The latter is used >> for link control, as well as pipe3 attachment and detachment. >> >> Add a new driver for it. >> >> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx> >> --- >> drivers/phy/samsung/Kconfig | 13 ++ >> drivers/phy/samsung/Makefile | 1 + >> drivers/phy/samsung/phy-exynos2200-usbcon.c | 241 ++++++++++++++++++++ >> include/linux/soc/samsung/exynos-regs-pmu.h | 3 + >> 4 files changed, 258 insertions(+) >> create mode 100644 drivers/phy/samsung/phy-exynos2200-usbcon.c >> >> diff --git a/drivers/phy/samsung/Kconfig b/drivers/phy/samsung/Kconfig >> index f62285254..47e9b9926 100644 >> --- a/drivers/phy/samsung/Kconfig >> +++ b/drivers/phy/samsung/Kconfig >> @@ -90,6 +90,19 @@ config PHY_EXYNOS2200_SNPS_EUSB2 >> This driver provides PHY interface for eUSB 2.0 controller >> present on Exynos5 SoC series. >> >> +config PHY_EXYNOS2200_USBCON >> + tristate "Exynos2200 USBCON PHY driver" >> + depends on (ARCH_EXYNOS && OF) || COMPILE_TEST >> + depends on HAS_IOMEM >> + depends on USB_DWC3_EXYNOS > How? What are you using from DWC3? Will drop. > >> + select GENERIC_PHY >> + select MFD_SYSCON >> + default y >> + help >> + Enable USBCON PHY support for Exynos2200 SoC. >> + This driver provides PHY interface for USB controller present >> + on Exynos2200 SoC. >> + >> config PHY_EXYNOS5_USBDRD >> tristate "Exynos5 SoC series USB DRD PHY driver" >> depends on (ARCH_EXYNOS && OF) || COMPILE_TEST >> diff --git a/drivers/phy/samsung/Makefile b/drivers/phy/samsung/Makefile >> index 90b84c7fc..f70e12ddf 100644 >> --- a/drivers/phy/samsung/Makefile >> +++ b/drivers/phy/samsung/Makefile >> @@ -15,5 +15,6 @@ phy-exynos-usb2-$(CONFIG_PHY_EXYNOS4X12_USB2) += phy-exynos4x12-usb2.o >> phy-exynos-usb2-$(CONFIG_PHY_EXYNOS5250_USB2) += phy-exynos5250-usb2.o >> phy-exynos-usb2-$(CONFIG_PHY_S5PV210_USB2) += phy-s5pv210-usb2.o >> obj-$(CONFIG_PHY_EXYNOS2200_SNPS_EUSB2) += phy-exynos2200-snps-eusb2.o >> +obj-$(CONFIG_PHY_EXYNOS2200_USBCON) += phy-exynos2200-usbcon.o >> obj-$(CONFIG_PHY_EXYNOS5_USBDRD) += phy-exynos5-usbdrd.o >> obj-$(CONFIG_PHY_EXYNOS5250_SATA) += phy-exynos5250-sata.o >> diff --git a/drivers/phy/samsung/phy-exynos2200-usbcon.c b/drivers/phy/samsung/phy-exynos2200-usbcon.c >> new file mode 100644 >> index 000000000..7968c9792 >> --- /dev/null >> +++ b/drivers/phy/samsung/phy-exynos2200-usbcon.c >> @@ -0,0 +1,241 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (c) 2025, Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx> >> + */ >> + >> +#include <linux/bitfield.h> > Are you using this header? > >> +#include <linux/clk.h> >> +#include <linux/delay.h> >> +#include <linux/iopoll.h> > And rhis? > >> +#include <linux/mfd/syscon.h> >> +#include <linux/mod_devicetable.h> >> +#include <linux/phy/phy.h> >> +#include <linux/platform_device.h> >> +#include <linux/regmap.h> >> +#include <linux/regulator/consumer.h> >> +#include <linux/reset.h> > And this? Nope, it's a leftover I forgot to drop. Same with the above ... > Same comments as on previous patch. Alright. Thanks for the feedback! Best regards, Ivaylo > > > > Best regards, > Krzysztof
