W dniu 13.05.2015 o 13:01, Peter Chubb pisze:
>
> PWM output wasn't working because it wasn't hooked up to its pincontrol.
> This patch:
> - hooks up PWM to its pincontrol, and documents what
> the outputs are on the XU3
> - switches the LEDs that are on PWM outputs to use PWM
> rather than GPIO.
>
> The main effect is that the brightness of the LEDs can be controlled, and
> user-mode fan control is enabled via /sys/class/pwm
>
> Acked-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Signed-off-by: Peter Chubb <peter.chubb@xxxxxxxxxxxx>
> ---
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 56 +++++++++++++++++++++---------
> 1 file changed, 39 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index f0ce60b..6f96b3d 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -287,25 +287,35 @@
> status = "okay";
> };
>
> - leds {
> - compatible = "gpio-leds";
> - heartbeat {
> - label = "blue:heartbeart";
> - gpios = <&gpb2 2 0>;
> - default-state = "off";
> - linux,default-trigger = "heartbeat";
> - };
> -
> - eMMC {
> - label = "green:eMMC";
> - gpios = <&gpb2 1 0>;
> - default-state = "off";
> - linux,default-trigger = "mmc0";
> - };
> + pwmleds {
> + compatible = "pwm-leds";
> +
> + greenled {
> + label = "green:mmc0";
> + pwms = <&pwm 1 2000000 0>;
> + pwm-names = "pwm1";
> + /*
> + * Green LED is much brighter than the others
> + * so limit its max brightness
> + */
> + max_brightness = <127>;
Please run checkpatch before sending a patch. Here you have trailing
whitespace error.
Additionally the indentation is broken in most of the lines - mixed tabs
with spaces. Just stick to the kernel coding convention - tabs (8
characters wide).
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
