2015-05-12 9:29 GMT+09:00 Peter Chubb <peter.chubb@xxxxxxxxxxxx>:
>
> PWM output on the XU3 wasn't working because it wasn't hooked up to
> its pincontrol.
Hi,
Use a common convention of patch title - prefix with "ARM: dts:" and
optionally name of the board. Just look at previous commits in
arch/arm/boot/dts/.
>
> This patch:
> -- hooks up PWM to its pincontrol, and documents what
> the outputs are on the XU3
> -- switches the LEDs that are on PWM outputs to use PWM
> rather than GPIO.
>
> The main effect is that the brightness of the LEDs can be controlled, and
> user-mode fan control is enabled via /sys/class/pwm
>
> The patch is against the for-next branch of the linux-samsung tree.
>
> Signed-off-by: Peter Chubb <peter.chubb@xxxxxxxxxxxx>
> ---
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 55 +++++++++++++++++++++---------
> 1 file changed, 39 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index 026f83e..84d71a1 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -13,6 +13,7 @@
> /dts-v1/;
> #include <dt-bindings/gpio/gpio.h>
> #include "exynos5800.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> model = "Hardkernel Odroid XU3";
> @@ -287,25 +288,47 @@
> status = "okay";
> };
>
> - leds {
> - compatible = "gpio-leds";
> - heartbeat {
> - label = "blue:heartbeart";
> - gpios = <&gpb2 2 0>;
> - default-state = "off";
> - linux,default-trigger = "heartbeat";
> - };
> + pwm: pwm@12dd0000 {
The label for node is already specified in exynos5420.dtsi. Don't
duplicate it. Actually when overriding nodes you should use
label-convention:
&pwm {
...
};
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
