>>>>> "Krzysztof" == Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> writes: Krzysztof> 2015-05-12 9:29 GMT+09:00 Peter Chubb Krzysztof> <peter.chubb@xxxxxxxxxxxx>: >> >> PWM output on the XU3 wasn't working because it wasn't hooked up to >> its pincontrol. Krzysztof> Hi, Krzysztof> Use a common convention of patch title - prefix with "ARM: Krzysztof> dts:" and optionally name of the board. Just look at Krzysztof> previous commits in arch/arm/boot/dts/. Thanks I'll fix. Krzysztof> The label for node is already specified in Krzysztof> exynos5420.dtsi. Don't duplicate it. Actually when Krzysztof> overriding nodes you should use label-convention: &pwm { Krzysztof> ... }; I wasn't sure whether I shouldn't have changed exynos5422.dtsi rather than here, and just leave the "status = 'okay'" part for this file. What do you think? All exynos 54xx parts have the same PWM using the same pincontrol -- if it's enabled maybe it should be common? -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA ________________________________ The information in this e-mail may be confidential and subject to legal professional privilege and/or copyright. National ICT Australia Limited accepts no liability for any damage caused by this email or its attachments. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html