2015-05-12 10:25 GMT+09:00 Peter Chubb <peter.chubb@xxxxxxxxxxxx>:
>
> Krzysztof> The label for node is already specified in
> Krzysztof> exynos5420.dtsi. Don't duplicate it. Actually when
> Krzysztof> overriding nodes you should use label-convention: &pwm {
> Krzysztof> ... };
>
> I wasn't sure whether I shouldn't have changed exynos5422.dtsi
> rather than here, and just leave the "status = 'okay'" part for this file.
>
> What do you think? All exynos 54xx parts have the same PWM using the
> same pincontrol -- if it's enabled maybe it should be common?
>
You are actually overriding the node here, so I meant that instead of:
+ pwm: pwm@12dd0000 {
+ /*
+ * PWM 0 -- fan
+ * PWM 1 -- Green LED
+ * PWM 2 -- Blue LED
+ * PWM 3 -- on MIPI connector for backlight
+ */
+ pinctrl-0 = <&pwm0_out &pwm1_out &pwm2_out &pwm3_out>;
+ pinctrl-names = "default";
+ status = "okay";
+ };
do like:
+ &pwm {
+ /*
+ * PWM 0 -- fan
+ * PWM 1 -- Green LED
+ * PWM 2 -- Blue LED
+ * PWM 3 -- on MIPI connector for backlight
+ */
+ pinctrl-0 = <&pwm0_out &pwm1_out &pwm2_out &pwm3_out>;
+ pinctrl-names = "default";
+ status = "okay";
+ };
This does not require touching exynos5422.dtsi (there is no such file
:) ) or other DTSI.
As for generalizing this for other Exynos54xx boards - it depends if
the wires are the same. I don't know how it is connected on other
boards.
Additionally what is connected to the GPIOs of the SoC is not usually
a property of the SoC but the board. So in such case it could go to a
common-board-DTSI file for but rather not for the SoC DTSI. Also then
it would require testing on these common boards.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
