On 05/12/15 09:29, Peter Chubb wrote:
>
> PWM output wasn't working because it wasn't hooked up to its pincontrol.
> This patch:
> -- hooks up PWM to its pincontrol, and documents what
don't use '--' can occur some confusing in git... just '-' is enough.
> the outputs are on the XU3
> -- switches the LEDs that are on PWM outputs to use PWM
> rather than GPIO.
>
> The main effect is that the brightness of the LEDs can be controlled, and
> user-mode fan control is enabled via /sys/class/pwm
the purpose of this patch looks good, but there are small comments.
>
> Signed-off-by: Peter Chubb <peter.chubb@xxxxxxxxxxxx>
> ---
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 58 +++++++++++++++++++++---------
> 1 file changed, 41 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index 026f83e..095282b 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -13,6 +13,7 @@
> /dts-v1/;
> #include <dt-bindings/gpio/gpio.h>
> #include "exynos5800.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
Don't add same inclusion.
>
> / {
> model = "Hardkernel Odroid XU3";
> @@ -287,25 +288,35 @@
> status = "okay";
> };
>
> - leds {
> - compatible = "gpio-leds";
> - heartbeat {
> - label = "blue:heartbeart";
> - gpios = <&gpb2 2 0>;
> - default-state = "off";
> - linux,default-trigger = "heartbeat";
> - };
> -
> - eMMC {
> - label = "green:eMMC";
> - gpios = <&gpb2 1 0>;
> - default-state = "off";
> - linux,default-trigger = "mmc0";
> - };
> + pwmleds {
> + compatible = "pwm-leds";
> +
> + greenled {
> + label = "green:mmc0";
> + pwms = <&pwm 1 2000000 0>;
> + pwm-names = "pwm1";
> + /*
> + * Green LED is much brighter than the others
> + * so limit its max brightness
> + */
> + max_brightness = <127>;
> + linux,default-trigger = "mmc0";
> + };
> +
> + blueled {
> + label = "blue:heartbeat";
> + pwms = <&pwm 2 2000000 0>;
> + pwm-names = "pwm2";
> + max_brightness = <255>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
>
> - microSD {
> + gpioleds {
> + compatible = "gpio-leds";
> + redled {
> label = "red:microSD";
> - gpios = <&gpx2 3 0>;
> + gpios = <&gpx2 3 GPIO_ACTIVE_HIGH>;
> default-state = "off";
> linux,default-trigger = "mmc1";
> };
I need to check about gpx2-3...
> @@ -411,3 +422,16 @@
> shunt-resistor = <10000>;
> };
> };
> +
> +&pwm {
> + /*
> + * PWM 0 -- fan
> + * PWM 1 -- Green LED
> + * PWM 2 -- Blue LED
> + * PWM 3 -- on MIPI connector for backlight
> + */
> + pinctrl-0 = <&pwm0_out &pwm1_out &pwm2_out &pwm3_out>;
> + pinctrl-names = "default";
> + status = "okay";
> +};
> +
Please don't add last empty line.
> --
> 2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
