On 05/25/11 11:15, Jassi Brar wrote:
diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
index a3fdfb6..a80eeb1 100644
--- a/sound/soc/samsung/Kconfig
+++ b/sound/soc/samsung/Kconfig
@@ -65,6 +65,9 @@ config SND_SOC_SAMSUNG_SMDK_WM8994
tristate "SoC I2S Audio support for WM8994 on SMDK"
depends on SND_SOC_SAMSUNG&& (MACH_SMDKV310 || MACH_SMDKC210)
select SND_SOC_WM8994
+ select MFD_SUPPORT
+ select I2C_S3C2410
+ select MFD_WM8994
I'm not sure about MFD configs, but if "select I2C_S3C2410" is required, it
should be moved into regarding Kconfig of arch/arm, because it is related to
dependency of ARCH. Maybe in this case, arch/arm/mach-exynos4/Kconfig?
I2C here is a SMDK specific requirement and even if most devices need I2C,
selecting I2C for every EXYNOS4210 based device is not ideal. IMO it'd better
be tied to some SMDK specific config option.
Hi Jassi :)
How are you?
Hmm...need to think again because as you know, basically all of boards
can be compiled with one exynos4_defconfig.
Ok, so you agreed it should be moved into some Kconfig of arch/arm/ :)
I will think again which one is more reasonable then let you know.
--
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
