Re: [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/24/11 21:39, Angus Ainslie wrote:
From: Giridhar Maruthy<giridhar.maruthy@xxxxxxxxxx>

Whenever I2S is selected, select MFD for WM8994 and I2C
to avoid manual enabling of the codec and I2C.

Signed-off-by: Giridhar Maruthy<giridhar.maruthy@xxxxxxxxxx>
Signed-off-by: Angus Ainslie<angus.ainslie@xxxxxxxxxx>
---
  sound/soc/samsung/Kconfig |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)


Hi Angus :)

Hmm...first of all, should add proper maintainers in Cc. In this case, Jassi, Liam, and Mark should be added in Cc. (Cc'ed them)

diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
index a3fdfb6..a80eeb1 100644
--- a/sound/soc/samsung/Kconfig
+++ b/sound/soc/samsung/Kconfig
@@ -65,6 +65,9 @@ config SND_SOC_SAMSUNG_SMDK_WM8994
  	tristate "SoC I2S Audio support for WM8994 on SMDK"
  	depends on SND_SOC_SAMSUNG&&  (MACH_SMDKV310 || MACH_SMDKC210)
  	select SND_SOC_WM8994
+	select MFD_SUPPORT
+	select I2C_S3C2410
+	select MFD_WM8994

I'm not sure about MFD configs, but if "select I2C_S3C2410" is required, it should be moved into regarding Kconfig of arch/arm, because it is related to dependency of ARCH. Maybe in this case, arch/arm/mach-exynos4/Kconfig?

diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
index e849f67..30b716e 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -12,6 +12,7 @@ if ARCH_EXYNOS4
 config CPU_EXYNOS4210
        bool
        select S3C_PL330_DMA
+       select I2C_S3C2410
        help
          Enable EXYNOS4210 CPU support

  	select SND_SAMSUNG_I2S
  	help
  		Say Y if you want to add support for SoC audio on the SMDKs.

--
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux