>> diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig >> index a3fdfb6..a80eeb1 100644 >> --- a/sound/soc/samsung/Kconfig >> +++ b/sound/soc/samsung/Kconfig >> @@ -65,6 +65,9 @@ config SND_SOC_SAMSUNG_SMDK_WM8994 >> Â Â Â Âtristate "SoC I2S Audio support for WM8994 on SMDK" >> Â Â Â Âdepends on SND_SOC_SAMSUNG&& Â(MACH_SMDKV310 || MACH_SMDKC210) >> Â Â Â Âselect SND_SOC_WM8994 >> + Â Â Â select MFD_SUPPORT >> + Â Â Â select I2C_S3C2410 >> + Â Â Â select MFD_WM8994 > > I'm not sure about MFD configs, but if "select I2C_S3C2410" is required, it > should be moved into regarding Kconfig of arch/arm, because it is related to > dependency of ARCH. Maybe in this case, arch/arm/mach-exynos4/Kconfig? I2C here is a SMDK specific requirement and even if most devices need I2C, selecting I2C for every EXYNOS4210 based device is not ideal. IMO it'd better be tied to some SMDK specific config option. Cheer! Jassi -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |