On Thu, Nov 30, 2023 at 05:22:33PM -0700, Nathan Chancellor wrote:
> When building with -Wmissing-prototypes without CONFIG_GENERIC_BUG,
> there is a warning about a missing prototype for is_valid_bugaddr():
>
> arch/s390/kernel/traps.c:46:5: warning: no previous prototype for 'is_valid_bugaddr' [-Wmissing-prototypes]
> 46 | int is_valid_bugaddr(unsigned long addr)
> | ^~~~~~~~~~~~~~~~
>
> The prototype is only declared with CONFIG_GENERIC_BUG, so only define
> the function under the same condition to clear up the warning, which
> matches other architectures.
>
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> ---
> arch/s390/kernel/traps.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/s390/kernel/traps.c b/arch/s390/kernel/traps.c
> index 1d2aa448d103..cc3e3a01dfa5 100644
> --- a/arch/s390/kernel/traps.c
> +++ b/arch/s390/kernel/traps.c
> @@ -43,10 +43,12 @@ static inline void __user *get_trap_ip(struct pt_regs *regs)
> return (void __user *) (address - (regs->int_code >> 16));
> }
>
> +#ifdef CONFIG_GENERIC_BUG
> int is_valid_bugaddr(unsigned long addr)
> {
> return 1;
> }
> +#endif
>
> void do_report_trap(struct pt_regs *regs, int si_signo, int si_code, char *str)
> {
Reviewed-by: Alexander Gordeev <agordeev@xxxxxxxxxxxxx>
