Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/26/21 10:37 PM, Biju Das wrote:
[...]

>>>>>> Do you agree GAC register(gPTP active in Config) bit in AVB-DMAC
>> mode register(CCC) present only in R-Car Gen3?
>>>>>
>>>>>    Yes.
>>>>>    But you feature naming is totally misguiding, nevertheless...
>>>>
>>>> It can still be changed.
>>>
>>>     Thank goodness, yea!
>>
>> We have to live with the first version of this in the git history, but we
>> can add more patches fixing up whatever is broken in the unreviewed code
>> which got merged.
>>
>>>> Just suggest a new name.
>>>
>>>     I'd prolly go with 'gptp' for the gPTP support and 'ccc_gac' for
>>> the gPTP working also in CONFIG mode (CCC.GAC controls this feature).
>>
>> Biju, please could you work on a couple of patches to change the names.
> 
> Yes. Will work on the patches to change the names as suggested. 

   TIA!
   After some more thinking, 'no_gptp' seems to suit better for the 1st case
Might need to invert the checks tho...

[...]

> Cheers,
> Biju

MBR, Sergey



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux