Hi Andrew, Thanks for the feedback. > Subject: Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct > ravb_hw_info > > On Thu, Aug 26, 2021 at 10:02:07PM +0300, Sergey Shtylyov wrote: > > On 8/26/21 9:57 PM, Andrew Lunn wrote: > > > > >>> Do you agree GAC register(gPTP active in Config) bit in AVB-DMAC > mode register(CCC) present only in R-Car Gen3? > > >> > > >> Yes. > > >> But you feature naming is totally misguiding, nevertheless... > > > > > > It can still be changed. > > > > Thank goodness, yea! > > We have to live with the first version of this in the git history, but we > can add more patches fixing up whatever is broken in the unreviewed code > which got merged. > > > > Just suggest a new name. > > > > I'd prolly go with 'gptp' for the gPTP support and 'ccc_gac' for > > the gPTP working also in CONFIG mode (CCC.GAC controls this feature). > > Biju, please could you work on a couple of patches to change the names. Yes. Will work on the patches to change the names as suggested. > > I also suggest you post further refactoring patches as RFC. We might get a > chance to review them then. Agreed. Cheers, Biju
