Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx>
Subject: Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
From: Andrew Lunn <andrew@xxxxxxx>
Date: Thu, 26 Aug 2021 20:57:34 +0200
Cc: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>, Sergey Shtylyov <s.shtylyov@xxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Adam Ford <aford173@xxxxxxxxx>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "linux-renesas-soc@xxxxxxxxxxxxxxx" <linux-renesas-soc@xxxxxxxxxxxxxxx>, Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>, Biju Das <biju.das@xxxxxxxxxxxxxx>
In-reply-to: <93dab08c-4b0b-091d-bd47-6e55bce96f8a@gmail.com>
References: <20210825070154.14336-1-biju.das.jz@bp.renesas.com> <20210825070154.14336-5-biju.das.jz@bp.renesas.com> <777c30b1-e94e-e241-b10c-ecd4d557bc06@omp.ru> <OS0PR01MB59220BCAE40B6C8226E4177986C79@OS0PR01MB5922.jpnprd01.prod.outlook.com> <78ff279d-03f1-6932-88d8-1eac83d087ec@omp.ru> <OS0PR01MB59223F0F03CC9F5957268D2086C79@OS0PR01MB5922.jpnprd01.prod.outlook.com> <9b0d5bab-e9a2-d9f6-69f7-049bfb072eba@omp.ru> <OS0PR01MB5922F8114A505A33F7A47EB586C79@OS0PR01MB5922.jpnprd01.prod.outlook.com> <93dab08c-4b0b-091d-bd47-6e55bce96f8a@gmail.com>

> > Do you agree GAC register(gPTP active in Config) bit in AVB-DMAC mode register(CCC) present only in R-Car Gen3?
> 
>    Yes.
>    But you feature naming is totally misguiding, nevertheless...

It can still be changed. Just suggest a new name.

   Andrew

Follow-Ups:
- Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
  - From: Sergey Shtylyov

References:
- [PATCH net-next 00/13] Add Factorisation code to support Gigabit Ethernet driver
  - From: Biju Das
- [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
  - From: Biju Das
- Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
  - From: Sergey Shtylyov
- RE: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
  - From: Biju Das
- Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
  - From: Sergey Shtylyov
- RE: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
  - From: Biju Das
- Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
  - From: Sergey Shtylyov
- RE: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
  - From: Biju Das
- Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
  - From: Sergei Shtylyov

Prev by Date: Re: [PATCH net-next 06/13] ravb: Factorise ravb_ring_format function
Next by Date: Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
Previous by thread: Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
Next by thread: Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SOC] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]