Hi Sergei, On Mon, Oct 7, 2019 at 1:49 PM Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > On 10/07/2019 02:45 PM, Geert Uytterhoeven wrote: > >> I was unable to get clk_set_rate() setting a lower RPC-IF clock frequency > >> and that issue boiled down to me not passing CLK_SET_RATE_PARENT flag to > >> clk_register_composite() when registering the RPC[D2] clocks... > >> > >> Fixes: db4a0073cc82 ("clk: renesas: rcar-gen3: Add RPC clocks") > >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > > > > Thanks for your patch! > > > > LGTM, so > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Thanks. :-) > > > Now, before I apply this: does this make RPC-IF work? > > Unfortunately, no. :-/ As per private communication, I understand the problem is elsewhere, and this patch itself is working fine, and thus safe to apply? Thanks for confirming! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds