On Tue, 2017-12-05 at 16:31 +0100, Linus Walleij wrote: > On Tue, Dec 5, 2017 at 2:38 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> > wrote: > > Two statice inlines in <linux/gpio/consumer.h> > named > > int gpiod_is output() > int gpiod_is_input() Ha, just proposed similar. > > should conform to Rusty Russell's API hierarchy. > > Interested in fixing it, or should I? > I can almost ACK it before you write the patch. I vote for this type of API, and agree with Wolfram !_get_direction() is confusing. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy