On Mon, Dec 4, 2017 at 1:36 PM, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > This will be needed when we want to create STOP conditions, too, later. > Create the needed fields and populate them for the GPIO case if the GPIO > is set to output. > > Cc: Phil Reid <preid@xxxxxxxxxxxxxxxxx> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Cc: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> > Cc: Claudio Foellmi <claudio.foellmi@xxxxxxxx> > Cc: Andrzej Hajda <a.hajda@xxxxxxxxxxx> > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> (...) > #include <linux/errno.h> > +#include <linux/gpio.h> Please no. > + if (gpiod_get_direction(bri->sda_gpiod) == GPIOF_DIR_OUT) > + bri->set_sda = set_sda_gpio_value; Just compare it to zero. if (!gpiod_get_direction()) This flag is only for requesting GPIOs in the old API. We didn't add a define in the new API, it seemed overengineered. Yours, Linus Walleij
