On Tue, Dec 5, 2017 at 2:38 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: >> Just compare it to zero. if (!gpiod_get_direction()) > > So, this? > > if (!gpiod_get_direction()) > bri->set_sda = set_sda_gpio_value; > > That looks like "if i couldn't the direction, then...", or? > > Comparing to plain numbers feels like magic values? Hehe :) > Maybe this should be named 'gpiod_is_direction_input()'? Two statice inlines in <linux/gpio/consumer.h> named int gpiod_is output() int gpiod_is_input() should conform to Rusty Russell's API hierarchy. Interested in fixing it, or should I? I can almost ACK it before you write the patch. Yours, Linus Walleij
