On Mon, 2017-12-04 at 13:36 +0100, Wolfram Sang wrote: > This will be needed when we want to create STOP conditions, too, > later. > Create the needed fields and populate them for the GPIO case if the > GPIO > is set to output. > +#include <linux/gpio.h> > #include <linux/gpio/consumer.h> I think it should be not done like this. (Yes, I know why you did that) Perhaps Linus will accept a patch to move direction flags to some header feasible via consumer.h. Linus? Or if we wish to hide: static inline bool gpiod_is_direction_out() {} static inline bool gpiod_is_direction_in() {} > if (gpiod_get_direction(bri->sda_gpiod) == GPIOF_DIR_OUT) P.S. Yep, I saw some other upstreamed patch doing this kind of comparison. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy