Hi Geert-san,
> -----Original Message-----
> From: Geert Uytterhoeven, Sent: Tuesday, October 3, 2017 4:13 PM
>
> Hi Shimoda-san,
>
> On Tue, Oct 3, 2017 at 5:13 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
<snip>
> > I'm afraid but I completely misunderstood the pin configurations on the Salvator-XS.
> > I wrote right things below:
> > - USB2.0 ch3 pins are GP6_30 and GP6_31.
>
> OK.
>
> > - So, initial setting of the board will be conflict with the adv7482's interrupt pins.
>
> Initial setting of SW31 is ON-ON-OFF-OFF-OFF-OFF, cfr. Section 2.1.22
> ("SW31 (Selects GPIO/USB Connection) Specifications") of the
> Salvator-XS setup manual,
> which is meant to accommodate the ADV7482 on both H3 and M3-W, like
> was done on Salvator-X.
Yes.
<snip>
> > - Summary
> > - We describe the adv7482's interrupt pins into both salvator-x.dtsi and salvator-xs.dtsi.
> > - In salvator-x.dtsi, adv7482 node uses GP6_30 and GP6_31.
> > - In salvator-xs.dtsi, adv7482 node uses GP6_04 and GP6_21.
>
> While you could do this in salvator-xs.dtsi, doing so would mean users of
> Salvator-X with M3-W have to change SW31 from the default configuration to
> OFF-OFF-OFF-OFF-ON-ON (Note: we don't have r8a7796-salvator-xs.dts in
> mainline yet).
Yes.
> > - We describe the usb2 ch3 pfc node into r8a7795-salvator-xs.dtsi with "usb2_ch3" groups/function and
> > describe the SW31 configuration.
> >
> > What do you think?
>
> I would keep the ADV7482 in salvator-common.dtsi using the GP6_3[01]
> interrupts, like is done now.
>
> In r8a7795-salvator-xs.dtsi, you can override the interrupts property to
> GP6_{04,21}, with a comment saying:
> 1. This is done to support the "usb2_ch3" pin group, and,
> 2. This requires changing SW31 to OFF-OFF-ON-ON-ON-ON.
>
> Users of Salvator-XS with M3-W don't have to change anything.
>
> Does this sound OK?
It sounds good to me! I guess Kieran-san will do the "override the interrupt property"
when he supports ADV7482 :)
Best regards,
Yoshihiro Shimoda
> Simon?
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
