Hi Geert, Shimoda-san,
On 02/10/17 09:20, Geert Uytterhoeven wrote:
> Hi Shimoda-san,
>
> On Mon, Oct 2, 2017 at 8:29 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
>> This patch enables the USB2.0 phy channel 3. R-Car H3 ES2.0 has
>> this channel and we can use it on the Salvator-XS.
>>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
>> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
>> @@ -99,6 +99,11 @@
>> groups = "usb2";
>> function = "usb2";
>> };
>> +
>> + usb2_ch3_pins: usb2_ch3 {
>> + groups = "usb2_ch3";
>> + function = "usb2_ch3";
>> + };
>> };
>
> Using these pins requires changing SW31, disabling the interrupt capabilities
> of the ADV7482? Does the ADV7482 still work after that?
The ADV7482 is currently working without interrupts at the moment. However, I do
have hotplug and interrupt handling on my todo list, and infact I have already
started a patch adding interrupt support.
The DT currently specifies the following interrupts for the ADV7482,
+ video-receiver@70 {
+ compatible = "adi,adv7482";
+ interrupt-parent = <&gpio6>;
+ interrupt-names = "intrq1", "intrq2";
+ interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
+ <31 IRQ_TYPE_LEVEL_LOW>;
And the start of interrupt handling looks like: (this is not integrated, nor
finished):
https://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git/commit/?h=adv748x/dev&id=82c7d0100edd28fa429c3811c575bad7a4d92cfd
This purely registers the interrupts currently; so if I need to do anything
differently to handle the USB2 conflict, please let me know.
As for going forwards, I believe that the ADV7482 can actually configure what
interrupts are triggered on either interrupt source, (INTRQ1/INTRQ2) and
therefore we could potentially get by with only INTRQ1, (INT 30) if we needed
to; however it would be good to handle this conflict in a generic way.
Regards
Kieran
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
