Hi Shimoda-san,
On Mon, Oct 2, 2017 at 11:14 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
>> -----Original Message-----
>> From: Kieran Bingham
>> Sent: Monday, October 2, 2017 5:45 PM
>> On 02/10/17 09:20, Geert Uytterhoeven wrote:
>> > On Mon, Oct 2, 2017 at 8:29 AM, Yoshihiro Shimoda
>> > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
>> >> This patch enables the USB2.0 phy channel 3. R-Car H3 ES2.0 has
>> >> this channel and we can use it on the Salvator-XS.
>> >>
>> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>> >
>> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>> >
>> >> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
>> >> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
>> >> @@ -99,6 +99,11 @@
>> >> groups = "usb2";
>> >> function = "usb2";
>> >> };
>> >> +
>> >> + usb2_ch3_pins: usb2_ch3 {
>> >> + groups = "usb2_ch3";
>> >> + function = "usb2_ch3";
>> >> + };
>> >> };
>> >
>> > Using these pins requires changing SW31, disabling the interrupt capabilities
>> > of the ADV7482? Does the ADV7482 still work after that?
>
> Oops, I missed the usb2.0 pins are connected to ADV7482's interruption pins.
> But,
>
>> The ADV7482 is currently working without interrupts at the moment. However, I do
>> have hotplug and interrupt handling on my todo list, and infact I have already
>> started a patch adding interrupt support.
>>
>>
>> The DT currently specifies the following interrupts for the ADV7482,
>>
>> + video-receiver@70 {
>> + compatible = "adi,adv7482";
>> + interrupt-parent = <&gpio6>;
>> + interrupt-names = "intrq1", "intrq2";
>> + interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
>> + <31 IRQ_TYPE_LEVEL_LOW>;
>
> It seems Kieran-san is using non-conflict pins with usb2.0 ch3 :)
> According to the board datasheet, GP6_30 and GP6_31 are initial setting for ADV7482 and
> it doesn't conflict with USB 2.0 ch3 (USB2.0 ch3 pins are GP6_04 and GP6_21).
Can the USB2.0 driver use GPIOs for PWEN and OVC?
> So, I think we can use both usb 2.0 ch3 and ADV7482 if we don't change the SW31 from initial setting.
OK. But in that case, DT should not configure pinctrl for "usb2_ch3",
but instead
describe that it uses GP6_04 and GP6_21.
> However, to avoid any trouble, should we explain this SW31 setting in the dts file?
Yes, it would be good to document that.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
