On Mon, Oct 02, 2017 at 09:16:56AM +0000, Yoshihiro Shimoda wrote:
> Hi Simon-san,
>
> > -----Original Message-----
> > From: Simon Horman
> > Sent: Monday, October 2, 2017 4:15 PM
> >
> > On Mon, Oct 02, 2017 at 01:18:49AM +0000, Yoshihiro Shimoda wrote:
> > > Hello,
> > >
> > > > -----Original Message-----
> > > > From: Sergei Shtylyov
> > > > Sent: Saturday, September 30, 2017 7:24 PM
> > > >
> > > > Hello!
> > > >
> > > > On 9/29/2017 2:52 PM, Simon Horman wrote:
> > > >
> > > > > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > > > >
> > > > > This patch enables EthernetAVB for R-Car D3 draak board.
> > > > >
> > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > > > > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> > > > > ---
> > > > > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 +++++++++++++++++++++++++
> > > > > 1 file changed, 25 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > > > index 7b776cb7e928..96b7ff5cc321 100644
> > > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > > [...]
> > > > > @@ -37,6 +39,14 @@
> > > > > };
> > > > >
> > > > > &pfc {
> > > > > + avb0_pins: avb {
> > > > > + mux {
> > > > > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc",
> > > > ^^^^^^^^^^^^^^
> > > > Hum, I don't think it's compatible with routing the PHY interrupt via
> > > > GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT anyway.
> > >
> > > Oops! You're correct. I should drop "avb0_phy_int".
> > >
> > > Simon-san, may I send a follow-up patch to fix this?
> >
> > Thanks Sergei, thanks Shimoda-san,
> >
> > yes, please provide a follow-up patch.
> >
> > At this stage I don't think we need to re-spin this pull-request
> > to fix this, rather a follow-up patch can be included
> > in a follow-up pull request.
>
> I got it. I will send it. Also, should I send salvator-common and ulcb patches
> about Geert-san's comment (These dtsi files also enable "avb_phy_int" for now)?
Hi Shimoda-san,
yes, I think that would be best.
Please include Fixes tags.
