On 24/02/17 15:48, jacopo mondi wrote: > Hi Lars-Peter, > > On 24/02/2017 16:33, Lars-Peter Clausen wrote: >> On 02/24/2017 04:22 PM, Geert Uytterhoeven wrote: >>> On Fri, Feb 24, 2017 at 4:05 PM, Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> wrote: >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/iio/adc/max961x.txt >>>> @@ -0,0 +1,27 @@ >>>> +* Maxim max9611/max9612 current sense amplifier with 12-bits ADC interface >>>> + >>>> +Maxim max9611/max9612 is an high-side current sense amplifier with integrated >>>> +12-bits ADC communicating over I2c bus. >>>> +The device node for this driver shall be a child of a I2c controller. >>>> + >>>> +Required properties >>>> + - compatible: Should be "maxim,max961x" >>>> + - reg: The 7-bits long I2c address of the device >>>> + - shunt-resistor: Resistor value, in uOhm, of the current sense shunt >>>> + resistor. >>> >>> shunt-resistor-micro-ohms? >> >> I'll take this one further: >> >> maxim,shunt-resistor-micro-ohms? >> >> Although there is precedence for just 'shunt-resistor' in the ina2xx bindings. >> > > And that's where I took "inspiration" from :) Which raises another open question. Why IIO rather than hwmon like the ina2xx? cc'd Guenter and hwmon list. I don't typically have strong opinions on this but best to make sure everyone is happy. Always best to layout your thinking on this in the cover letter. I'll raise it there as well but came to mind when seeing the ina2xx reference here. Whether we are better going for the existing binding without units, or 'fixing' that is a question for the device tree maintainers. I guess that one snuck through. Jonathan > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html
