On Mon, Mar 07, 2016 at 10:00:37PM +0100, Geert Uytterhoeven wrote: > CC Shawn, Sascha for imx1 Sorry for the late response. > > On Mon, Mar 7, 2016 at 9:34 PM, Sergei Shtylyov > <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > > On 03/07/2016 11:29 PM, Geert Uytterhoeven wrote: > > > >>>>> --- a/drivers/pinctrl/sh-pfc/core.c > >>>>> +++ b/drivers/pinctrl/sh-pfc/core.c > >>>>> @@ -545,7 +545,9 @@ static int sh_pfc_probe(struct platform_device > >>>>> *pdev) > >>>>> return ret; > >>>>> } > >>>>> > >>>>> - pinctrl_provide_dummies(); > >>>>> + /* Enable dummy states for those platforms without pinctrl > >>>>> support */ > >>>>> + if (!of_have_populated_dt()) > >>> > >>> > >>> I'd considered this condition -- it won't fly on SH where > >>> CONFIG_OF=n, > >>> the kernel just won't build IIUC... > >> > >> > >> I haven't tried to compile it yet, but <linux/of.h> does provide a dummy > >> that > >> returns false. > > > > > > Oops, indeed. I missed it. :-( > > This approach is better then, won't have to fix again whenever SH gets DT > > support. > > Perhaps the of_have_populated_dt() check should be moved inside > pinctrl_provide_dummies()? > > Besides omap2, which has its own check, the only other user is imx1. > Does imx1 (still) needs this on DT-based platforms? > > (Context for Shawn and Sascha: > http://article.gmane.org/gmane.linux.kernel.renesas-soc/1639) pinctrl_provide_dummies() is only used on a few legacy i.MX platforms for non-DT boot, so it should be safe to move the check inside the function from i.MX view. Shawn
