On Mon, Mar 7, 2016 at 9:02 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: >>> --- a/drivers/pinctrl/sh-pfc/core.c >>> +++ b/drivers/pinctrl/sh-pfc/core.c >>> @@ -545,7 +545,9 @@ static int sh_pfc_probe(struct platform_device *pdev) >>> return ret; >>> } >>> >>> - pinctrl_provide_dummies(); >>> + /* Enable dummy states for those platforms without pinctrl >>> support */ >>> + if (!of_have_populated_dt()) > > I'd considered this condition -- it won't fly on SH where CONFIG_OF=n, > the kernel just won't build IIUC... I haven't tried to compile it yet, but <linux/of.h> does provide a dummy that returns false. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds