Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/07/2016 11:29 PM, Geert Uytterhoeven wrote:

--- a/drivers/pinctrl/sh-pfc/core.c
+++ b/drivers/pinctrl/sh-pfc/core.c
@@ -545,7 +545,9 @@ static int sh_pfc_probe(struct platform_device *pdev)
                          return ret;
          }

-       pinctrl_provide_dummies();
+       /* Enable dummy states for those platforms without pinctrl
support */
+       if (!of_have_populated_dt())

    I'd considered this condition -- it won't fly on SH where CONFIG_OF=n,
the kernel just won't build IIUC...

I haven't tried to compile it yet, but <linux/of.h> does provide a dummy that
returns false.

   Oops, indeed. I missed it. :-(
This approach is better then, won't have to fix again whenever SH gets DT support.

Gr{oetje,eeting}s,

                         Geert

MBR, Sergei




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux