Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms

Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> · Mon, 7 Mar 2016 23:34:19 +0300

On 03/07/2016 11:29 PM, Geert Uytterhoeven wrote:

--- a/drivers/pinctrl/sh-pfc/core.c
+++ b/drivers/pinctrl/sh-pfc/core.c
@@ -545,7 +545,9 @@ static int sh_pfc_probe(struct platform_device *pdev)
                          return ret;
          }

-       pinctrl_provide_dummies();
+       /* Enable dummy states for those platforms without pinctrl
support */
+       if (!of_have_populated_dt())

    I'd considered this condition -- it won't fly on SH where CONFIG_OF=n,
the kernel just won't build IIUC...

I haven't tried to compile it yet, but <linux/of.h> does provide a dummy that
returns false.

   Oops, indeed. I missed it. :-(
   This approach is better then, won't have to fix again whenever SH gets DT 
support.

Gr{oetje,eeting}s,

                         Geert

MBR, Sergei







