Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linus,

On Wed, Mar 9, 2016 at 11:32 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Wed, Mar 9, 2016 at 4:58 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
>> On Mon, Mar 07, 2016 at 10:00:37PM +0100, Geert Uytterhoeven wrote:
>
>>> >    This approach is better then, won't have to fix again whenever SH gets DT
>>> > support.
>>>
>>> Perhaps the of_have_populated_dt() check should be moved inside
>>> pinctrl_provide_dummies()?
>>
>> I suggest we pick up this patch now even with stable tag (the irq storm
>> fixup doesn't work correctly because of this) and consider the
>> refactoring as a second step?
>
> Sergei, Geert, do you ACK this?

I gave this a try on all my boards, plus the remote r8a7790/lager that
exhibited the problem.

Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Please pick it up. Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux