On 2019-10-23 08:33, Honggang LI wrote: > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c > index b7f7a5f7bd98..96434f743a91 100644 > --- a/drivers/infiniband/ulp/srp/ib_srp.c > +++ b/drivers/infiniband/ulp/srp/ib_srp.c > @@ -74,6 +74,7 @@ static bool allow_ext_sg; > static bool prefer_fr = true; > static bool register_always = true; > static bool never_register; > +static bool has_max_it_iu_size = true; > static int topspin_workarounds = 1; > > module_param(srp_sg_tablesize, uint, 0444); > @@ -103,6 +104,10 @@ module_param(register_always, bool, 0444); > MODULE_PARM_DESC(register_always, > "Use memory registration even for contiguous memory regions"); > > +module_param(has_max_it_iu_size, bool, 0444); > +MODULE_PARM_DESC(has_max_it_iu_size, > + "Indicate the module supports max_it_iu_size login parameter"); > + > module_param(never_register, bool, 0444); > MODULE_PARM_DESC(never_register, "Never register memory"); > > ============== > Then, srp_daemon should check file "/sys/module/ib_srp/parameters/has_max_it_iu_size" > instead of "/sys/module/ib_srp/parameters/use_imm_data". This should work but I'm not sure this is the best approach we can come up with. Will one new kernel module parameter be added to the ib_srp kernel module every time a login parameter is added? Thanks, Bart.
