On Thu, Oct 17, 2019 at 09:57:08PM -0700, Bart Van Assche wrote:
> On 2019-10-17 21:41, Honggang LI wrote:
> > + if (config->print_max_it_iu_size) {
> > + len += snprintf(target_config_str+len,
> > + sizeof(target_config_str) - len,
> > + ",max_it_iu_size=%d",
> > + be32toh(target->ioc_prof.send_size));
> > +
> > + if (len >= sizeof(target_config_str)) {
> > + pr_err("Target config string is too long, ignoring target\n");
> > + closedir(dir);
> > + return -1;
> > + }
> > + }
>
> Hi Honggang,
>
> I think this patch will make srp_daemon incompatible with versions of
^^^^^^^^^^^^
Yes, it compatible with old ib_srp kernel driver that do not support
the max_it_iu_size parameter. It will trigger a kernel message like
this:
ib_srp: unknown parameter or missing value 'max_it_iu_size=8276' in target creation request
But SRP login will continue and success.
> the ib_srp kernel driver that do not support the max_it_iu_size
> parameter and also that that's unacceptable. How about the following
> approach:
> * Do not add a new command-line option.
I suggest to use a new command-line, we can avoid the warning message by
remove the parameter from the srp_daemon commad.
> * Add max_it_iu_size at the end. I think that approach will trigger a
If we hard-code max_it_iu_size at the end, users with old srpt module
will not able to avoid the warn message. They have to use srp_daemon
without this patch.
thanks
> warning with older versions of the SRP kernel driver but also that it
> won't break SRP login.
>
> Thanks,
>
> Bart.
