On 10/18/19 8:22 AM, Honggang LI wrote:
[ ... ]
Hi Honggang,
The approach of your patch seems suboptimal to me. I think it would be
cumbersome for users to have to modify the srp_daemon_port@.service file
to suppress a kernel warning or to pass the max_it_iu_size parameter
during login.
Had you noticed that the SRP initiator stops parsing parameters if it
encounters an unrecognized parameter?
From ib_srp.c, function srp_parse_options():
default:
pr_warn("unknown parameter or missing value '%s' in"
" target creation request\n", p);
goto out;
}
The "goto out" breaks out of the while loop that parses options. We
cannot change this behavior in existing versions of the SRP initiator
kernel driver. In other words, if the max_it_iu_size parameter is not
specified at the very end of the login string it will cause some login
parameters to be ignored.
I think we should use one of the following two approaches:
* Not add a new command-line option to srp_daemon and add the
max_it_iu_size at the very end of the login string.
* Modify the ib_srp driver such that it exports the login parameters
through sysfs. Modify srp_daemon such that it only specifies the
max_it_iu_size parameter if it finds that parameter in the list of
supported parameters.
Thanks,
Bart.
