On 2019-10-17 21:41, Honggang LI wrote:
> + if (config->print_max_it_iu_size) {
> + len += snprintf(target_config_str+len,
> + sizeof(target_config_str) - len,
> + ",max_it_iu_size=%d",
> + be32toh(target->ioc_prof.send_size));
> +
> + if (len >= sizeof(target_config_str)) {
> + pr_err("Target config string is too long, ignoring target\n");
> + closedir(dir);
> + return -1;
> + }
> + }
Hi Honggang,
I think this patch will make srp_daemon incompatible with versions of
the ib_srp kernel driver that do not support the max_it_iu_size
parameter and also that that's unacceptable. How about the following
approach:
* Do not add a new command-line option.
* Add max_it_iu_size at the end. I think that approach will trigger a
warning with older versions of the SRP kernel driver but also that it
won't break SRP login.
Thanks,
Bart.
