On Thu, Mar 08, 2018 at 10:55:28AM -0700, Jason Gunthorpe wrote: > Hi Greg & Co, > > A question has come up in the infiniband/rdma space about what SPDX > license headers to use for some of our files. Which is a huge hint you should probably make it a lot simpler :) > I see in commit e2be04c7f9958dde770eeb8b30e829ca969b37bb you added > this header: > > --- a/include/uapi/rdma/ib_user_sa.h > +++ b/include/uapi/rdma/ib_user_sa.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) */ > /* > > However, following the matching guidelines at spdx.org, I don't get to > the same conclusion. Please read the text in Documentation/process/license_rules.rst for the matching guidelines here. It did diverge a bit from spdx, but not in a way that should be incompatible. > The license in this file does not have the same 'disclaimer' text as > the reference BSD-2-Clause, which sounds like it shouldn't match based > on guideline 2.1.1 ? Then please tell me what exact license that file is trying to express, as it really looks like BSD-2-Clause to me. What were you intending to state here, something other than BSD-2? It better have not been a "custom" one :) > Specifically, the so-called 'OpenIB.org BSD license' is a mash up of > the first half of the 2 clause BSD license with the disclaimer > replaced with the disclaimer from the MIT license. Horrid mess, why in the world would you all do that :( > As I read the SPDX rules this license seems like it needs a new tag? Or fix the license of the text to be sane please, there's no need to make yet-another-license for something as "simple" as BSD-2-clause. Or even better, just drop the BSD mess, and stick with GPLv2 with syscall exception, which I'm pretty sure gives you everything you really want here anyway, right? > Alternatively, we can keep using the BSD-2-Clause tag if it was > determined that is correct for some reason? It really looks like this is BSD-2 to me, if not, please specify the exact license in the SPDX line. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
