On Sat, 2018-03-10 at 08:44 -0800, Linus Torvalds wrote:
> On Fri, Mar 9, 2018 at 3:26 PM, Doug Ledford <dledford@xxxxxxxxxx> wrote:
> >
> > The one
> > thing not in there is that I was getting ready to send the pull request
> > just leaving the munged commit message on Leon's patch in place, when
> > the thought to revert and reapply (versus a rebase as a fix) came to me
> > (I guess I don't revert much, so it didn't immediately come to mind as a
> > fix), so that revert and reapply was just done
>
> Please in general don't do a revert/reapply just for a commit message
> fix. The bad commit message remains, and the code remains the same, so
> you're only adding more noise to the logs rather than less.
>
> Yes, for "git blame" it can help (since git blame ends up finding the
> newer change with the new commit), but on the whole that probably
> isn't worth the pain.
>
> In this case the patch was pretty small, so I pulled it, but please
> don't make a habit of it. Be careful with the commit messages, and if
> it's something you really want to note, add a comment and a new commit
> message.
I mainly did it for the tags. If it were just the commit message I
would have skipped fixing it, but there was a syzkaller, stable, and
fixes tags all missing.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDDAttachment:
signature.asc
Description: This is a digitally signed message part
