On Fri, Mar 9, 2018 at 3:26 PM, Doug Ledford <dledford@xxxxxxxxxx> wrote:
>
> The one
> thing not in there is that I was getting ready to send the pull request
> just leaving the munged commit message on Leon's patch in place, when
> the thought to revert and reapply (versus a rebase as a fix) came to me
> (I guess I don't revert much, so it didn't immediately come to mind as a
> fix), so that revert and reapply was just done
Please in general don't do a revert/reapply just for a commit message
fix. The bad commit message remains, and the code remains the same, so
you're only adding more noise to the logs rather than less.
Yes, for "git blame" it can help (since git blame ends up finding the
newer change with the new commit), but on the whole that probably
isn't worth the pain.
In this case the patch was pretty small, so I pulled it, but please
don't make a habit of it. Be careful with the commit messages, and if
it's something you really want to note, add a comment and a new commit
message.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
