On Fri, Feb 09, 2018 at 09:51:38AM -0700, Jason Gunthorpe wrote: > On Fri, Feb 09, 2018 at 06:42:00PM +0200, Leon Romanovsky wrote: > > On Fri, Feb 09, 2018 at 09:13:25AM -0700, Jason Gunthorpe wrote: > > > On Fri, Feb 09, 2018 at 04:12:24PM +0000, Parav Pandit wrote: > > > > > > > > I did a patch that will make our public headers mostly strictly conforming to C11 > > > > > with -Wpedantic set, which I've been wondering if it is worth sending.. > > > > > > > Any reason to use open code instead of using BIT() macro from > > > > include/linux/bitops.h which does the same thing? > > > > > > BIT only works in the kernel. This is a publich header from rdma-core > > > userspace. > > > > ➜ rdma-core git:(master) git grep "define BIT" providers/mlx5/cq.c > > providers/mlx5/cq.c:#define BIT(i) (1UL << (i)) > > Still can't use it in a public header. Thanks, I missed that we are talking about mlx4dv.h Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
