Re: [PATCH rdma-core] mlx4: Fix 1<<31 expressions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 09, 2018 at 06:42:00PM +0200, Leon Romanovsky wrote:
> On Fri, Feb 09, 2018 at 09:13:25AM -0700, Jason Gunthorpe wrote:
> > On Fri, Feb 09, 2018 at 04:12:24PM +0000, Parav Pandit wrote:
> >
> > > > I did a patch that will make our public headers mostly strictly conforming to C11
> > > > with -Wpedantic set, which I've been wondering if it is worth sending..
> >
> > > Any reason to use open code instead of using BIT() macro from
> > > include/linux/bitops.h which does the same thing?
> >
> > BIT only works in the kernel. This is a publich header from rdma-core
> > userspace.
> 
> ➜  rdma-core git:(master) git grep "define BIT" providers/mlx5/cq.c
> providers/mlx5/cq.c:#define BIT(i) (1UL << (i))

Still can't use it in a public header.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux