On Fri, 2018-02-09 at 16:12 +0000, Parav Pandit wrote: > Any reason to use open code instead of using BIT() macro from > include/linux/bitops.h which does the same thing? Personally I'm in favor of removing the BIT() macro from the kernel. That macro is not useful and only adds confusion. Code that does not use that macro is easier to read because one does not have to look up whether the BIT() macro is defined as 1U << x, 1UL << x or 1ULL << x. Bart. ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f