> -----Original Message----- > From: Or Gerlitz [mailto:gerlitz.or@xxxxxxxxx] > Sent: Thursday, November 16, 2017 5:50 AM > To: Parav Pandit <parav@xxxxxxxxxxxx> > Cc: Doug Ledford <dledford@xxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; Hefty, > Sean <sean.hefty@xxxxxxxxx>; Leon Romanovsky <leonro@xxxxxxxxxxxx> > Subject: Re: [PATCH rdma-next 28/31] IB/cm: Fix avoid sleep while spin lock is > held > > On Thu, Nov 16, 2017 at 1:10 AM, Parav Pandit <parav@xxxxxxxxxxxx> wrote: > >> From: Or Gerlitz [mailto:gerlitz.or@xxxxxxxxx] > > >> Please also add more info (and in the cover letter please) on IPv4 vs > >> IPv6, unicast vs multicast, etc. > > > Is there a template that you can share that linux-rdma follows that I can use to > mention what tests are done? > > Any example past cover letters that I can refer as reference? > > I suggest you ask the sub-system maintainers (Doug, Jason) what do they expect > for such a heavy duty change set. > > > > Depending on how much information you expect in cover letter, this patchset > can have many revisions just for cover letter. > > So it would be best for you to share the template that I can fill in for v1. > > You are still on V0 and complaining on many revisions... > > >> You touched the CMA and addr modules quite heavily on all these > >> areas, need to cover them in testing. > > > Which are those tests that I should execute apart from above summary? > > If there is rdma verification suit @ mlnx that runs rdma user/kernel cm/cma > based applications on ib/roce environments, can run through it. > I have run such verification suit in RoCE environment. IB was not possible to run due to certain temporary setup constrains. However as I mentioned before, IB, perftests, rping, krping, iperf (IPoIB) were done for IB in VM and non VM servers. Same tests with RoCEv1, RoCEv2, IPv4 multicast with mckey, and tests related to IPv6 bug fixes are also ran. Certain errors related to timings are injected in code to test them for error path. > >> did you test APM? I don't think it would be correct to change the CM > >> APM code without proper testing. > > > As I already told this particular patch is not tested. All others are needless to > say tested. > > I do not have APM setup to test this fix. > > I am ok to drop this patch and provide fix when crash occurs later on. > > I suggest you ask the CM maintainer (Sean) for his opinion on that matter. You have already added him in CC list so if he has specifics I will let him respond. I haven't seen test confirmation from Roland for similar fix submitted last time in other cm handler. Leon, Once adequate review is done, let me know on how to proceed. I have additional 6 patches in one patchset that fixes two bugs for RoCE; without which certain users applications are broken for RoCE. Those fixes depend on this series. ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
